Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Fix EZP-27849: Fixed a parameter name in notification after delete content without sufficient permissions #898

Conversation

adamwojs
Copy link
Member

JIRA: https://jira.ez.no/browse/EZP-27849

Description

The failed.sending.to.trash translation unit expects %contentName% parameter. In the https://github.com/ezsystems/PlatformUIBundle/blob/master/Resources/public/js/views/services/ez-locationviewviewservice.js#L195 is passed %name% instead of %contentName%.

Steps to reproduce

  1. Create user without sufficient permissions to delete nodes
  2. Try to delete e.g folder
  3. There is not %contentName% value parameter in the error notification message text

Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but is stable branches affected? If so please rebase for 1.7 or 1.11 depending on what is relevant here.

@adamwojs adamwojs changed the base branch from master to 1.7 September 11, 2017 10:44
@adamwojs
Copy link
Member Author

@andrerom Done. I forgot about this while creating the PR ;-)

@andrerom andrerom merged commit 62995e5 into ezsystems:1.7 Sep 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants