This repository has been archived by the owner on May 3, 2022. It is now read-only.
EZP-2612: Expose the event name in the markup generated by UserMenuItemFireEventView #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @dpobel @yannickroger |
|
+1 |
| Y.Assert.areEqual( | ||
| this.view.get('eventName'), container.getAttribute('data-event-name'), | ||
| 'Should have the correct data event name value in the container' | ||
| //'Should pass to the container the correct event name' |
There was a problem hiding this comment.
I don't think this comment is needed, it's already specified in the test name.
|
besides niptick comment +1 |
miguelcleverti
force-pushed
the
exposeMenuFireEvent
branch
from
357846e to
c8c03ab
Compare
miguelcleverti
force-pushed
the
exposeMenuFireEvent
branch
from
c8c03ab to
9a6a572
Compare
|
ping @yannickroger @glye all green |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on PR #653 the event name should be exposed in order to the improve element searching in behat tests.
jira: https://jira.ez.no/browse/EZP-26121