Simplify install and add EE support with eZ Platform 1.11 + legacy 2017.08 #98

andrerom · 2017-07-13T18:07:11Z

Proposal for a ~~2.0.0~~ 1.3.0 release of legacy bridge, with aim to simplify installation. Implied in this simplification is also the need to provide a new legacy kernel release for use by community as well as potentially also eZ Enterprise users*.

There might also be other things that can be simplified, suggestions (PR's) welcome :)

* Afaik 5.4 legacy can't have features found in the 2017.08 milestone below needed for eZ Platform compatibility, and we don't intend to do a 5.5 release.

Bumps:

legacy installer: in order to skip install step about defining ezpublish-legacy-dir
legacy kernel: to be able to skip install steps about setting EZP_APP_FOLDER_NAME
eZ Platform kernel (ezpublish-kernel): for future parity with 2017.08 legacy kernel
- Note: some of these features depends on community contributions, and might not make it.

TODO:

Finalize and release legacy kernel 2017.08 and corresponding eZ Platform v1.11 release

Bump: - legacy installer in order to skip install step about defining `ezpublish-legacy-dir` - legacy kernel to be able to skip install steps about setting `EZP_APP_FOLDER_NAME`

emodric · 2017-07-13T18:54:50Z

Is 2.0.0 really needed? I don't feel that this is a breaking change that warrants major version bump and we could do with 1.3.0.

Other than that, 👍

emodric · 2017-07-13T18:55:42Z

composer.json

-        "ezsystems/ezpublish-legacy": ">=2014.11",
-        "ezsystems/ezpublish-kernel": "~6.0@dev",
+        "ezsystems/ezpublish-legacy-installer": "^2.0.4",
+        "ezsystems/ezpublish-legacy": ">=2017.08",


Should this be 2017.07?

Nope, that was what I first called it, but if we aim for parity with the features in the milestone, then that needs work also on platform side, hence 1.11 => august => 08 :)

andrerom · 2017-07-13T18:58:57Z

and we could do with 1.3.0.

I'm fine with that, but depends on if you or others have suggestions for what else we can do to further simplify the steps*.

* Like both you, @Plopix and @crevillo has attempted before. For instance could we add handling of legacy-installer to do some of the remaining steps? Among them enabling bundle and/or add post-update-cmd steps to composer.json

emodric · 2017-07-13T20:12:12Z

if you or others have suggestions for what else we can do to further simplify the steps.

Not right now, no.

emodric · 2017-07-13T21:13:49Z

For instance could we add handling of legacy-installer to do some of the remaining steps? Among them enabling bundle and/or add post-update-cmd steps to composer.json

We can try, but then composer would need to be ran twice, to take into account the new bundle and new scripts, which IMO is worse for DX than simply adding those beforehand.

Also, in cases where some of the legacy scripts are replaced by an overriden variant (for whatever reason), automatic update of composer.json would not be able to detect that unless it was somehow configurable.

Plopix · 2017-07-13T22:10:39Z

There are some settings to provide by default, to set up the Admin siteaccess etc.

bdunogier · 2017-07-20T08:23:08Z

If we don't have other changes that don't require a major version, I'd rather go with a minor one. When we have identified and implemented the changes that require one, we can still do it.

But I have no strong feelings here and might be missing something.

Good idea in any case !

andrerom · 2017-07-23T17:43:09Z

Changed to 1.3.0

There are some settings to provide by default, to set up the Admin site access etc.

@Plopix What did you have in mind here? something you think we can add here by default somehow?

emodric · 2017-07-24T09:22:57Z

@Plopix What did you have in mind here? something you think we can add here by default somehow?

@andrerom Maybe something like this: https://github.com/emodric/ezplatform-legacy/tree/master/ezpublish_legacy/settings ?

andrerom · 2017-07-31T11:54:51Z

INSTALL.md

-    "extra": {
-        "ezpublish-legacy-dir": "ezpublish_legacy",
-```
-
 ### Install `ezsystems/legacy-bridge`

 **Make sure you have set the ezpublish legacy folder in composer.json, as instructed above**


needs to be removed, but done in #103

andrerom · 2017-08-01T08:35:08Z

@andrerom Maybe something like this: https://github.com/emodric/ezplatform-legacy/tree/master/ezpublish_legacy/settings ?

Anything in particular there you mean we should inject via the bridge, or implying we should trigger legacy config generation somehow?

emodric · 2017-08-01T08:40:19Z

I don't think there's a need to generate anything. Nowdays, legacy bridge is used mostly for legacy admin, so just copying settings/siteaccess/admin and settings/override folders could be enough.

andrerom · 2017-08-01T08:48:37Z

hmm, well opting for admin as admin SiteAccess might or might not conflict with v2 admin, and reason I mentioned generation was to make sure we take the right settings from platform.

emodric · 2017-08-01T08:55:42Z

It can be done, sure. BTW, we're using Twig internally to do it when needed :)

Plopix · 2017-08-02T09:31:38Z

Sorry long delay for this reply. Yes I was thinking about the settings for the Legacy Admin (basically everything we can't inject through the new stack)
Like here: https://github.com/Plopix/LegacyBridge/tree/feature-install-doc/settings_template it is probably too much, but it is usually what I add for legacy admin override and the admin site access.

emodric · 2017-08-02T09:36:07Z

I would keep it optional in any case if done, not to collide with already existing configuration in existing sites.

[skip ci]

…form

andrerom · 2017-08-16T11:02:54Z

passing now, I assume your approval still stands @emodric ? :)

glye

(tiny speling nitpick)

glye · 2017-08-16T12:09:38Z

INSTALL.md

 ### Install `ezsystems/legacy-bridge`

-**Make sure you have set the ezpublish legacy folder in composer.json, as instructed above**
+`ezsystems/legacy-bridge` contains the libraries previous included in `ezsystems/ezpublish-kernel` in version 5.x.


previously included

andrerom added 4 commits July 13, 2017 19:42

[Composer] legacy installer 2.0.4 & legacy 2017.07

d076fd1

Bump: - legacy installer in order to skip install step about defining `ezpublish-legacy-dir` - legacy kernel to be able to skip install steps about setting `EZP_APP_FOLDER_NAME`

Update composer.json

e679200

[INSTALL] Remove steps not needed anymore

998a66b

Update composer.json

231ff52

emodric reviewed Jul 13, 2017

View reviewed changes

andrerom added 2 commits July 23, 2017 19:37

[INSTALL.md] Change to 1.3.0 release

bb4951b

[Composer] Change to 1.3.0 version

25d0a30

andrerom changed the title ~~[WIP] 2.0: Simplify install~~ [WIP] Simplify install Jul 23, 2017

andrerom changed the title ~~[WIP] Simplify install~~ [WIP] Simplify install 1.3.0 Jul 31, 2017

andrerom mentioned this pull request Jul 31, 2017

Simplify install for 1.2 branch #103

Closed

andrerom commented Jul 31, 2017

View reviewed changes

andrerom mentioned this pull request Aug 3, 2017

Basic PHP7 Compatibility netgen/ezpublish-kernel#22

Closed

emodric approved these changes Aug 16, 2017

View reviewed changes

andrerom added 2 commits August 16, 2017 12:04

Further cleanup

1319a06

[Composer] Allow legacy @dev to get tests to pass pre release

795c9fd

andrerom closed this Aug 16, 2017

andrerom deleted the simplify_install branch August 16, 2017 10:40

andrerom reopened this Aug 16, 2017

andrerom added 3 commits August 16, 2017 12:42

Typoes

587c1e6

[skip ci]

[Travis] Only run tests on PHP versions techcnially supported by plat…

01bb851

…form

[Travis] Drop PHP 7.2 testing for now, missing xdebug and more

8534e7d

andrerom requested a review from glye August 16, 2017 11:03

emodric approved these changes Aug 16, 2017

View reviewed changes

glye approved these changes Aug 16, 2017

View reviewed changes

Typo

21d1391

andrerom changed the title ~~[WIP] Simplify install 1.3.0~~ Simplify install and add EE support with eZ Platform 1.11 + legacy 2017.08 Aug 16, 2017

andrerom merged commit 62e11f4 into master Aug 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify install and add EE support with eZ Platform 1.11 + legacy 2017.08 #98

Simplify install and add EE support with eZ Platform 1.11 + legacy 2017.08 #98

andrerom commented Jul 13, 2017 •

edited

Loading

emodric commented Jul 13, 2017

emodric Jul 13, 2017

andrerom Jul 13, 2017

andrerom commented Jul 13, 2017 •

edited

Loading

emodric commented Jul 13, 2017

emodric commented Jul 13, 2017 •

edited

Loading

Plopix commented Jul 13, 2017

bdunogier commented Jul 20, 2017

andrerom commented Jul 23, 2017

emodric commented Jul 24, 2017

andrerom Jul 31, 2017

andrerom commented Aug 1, 2017

emodric commented Aug 1, 2017

andrerom commented Aug 1, 2017

emodric commented Aug 1, 2017

Plopix commented Aug 2, 2017

emodric commented Aug 2, 2017

andrerom commented Aug 16, 2017

glye left a comment

glye Aug 16, 2017

Simplify install and add EE support with eZ Platform 1.11 + legacy 2017.08 #98

Simplify install and add EE support with eZ Platform 1.11 + legacy 2017.08 #98

Conversation

andrerom commented Jul 13, 2017 • edited Loading

emodric commented Jul 13, 2017

emodric Jul 13, 2017

Choose a reason for hiding this comment

andrerom Jul 13, 2017

Choose a reason for hiding this comment

andrerom commented Jul 13, 2017 • edited Loading

emodric commented Jul 13, 2017

emodric commented Jul 13, 2017 • edited Loading

Plopix commented Jul 13, 2017

bdunogier commented Jul 20, 2017

andrerom commented Jul 23, 2017

emodric commented Jul 24, 2017

andrerom Jul 31, 2017

Choose a reason for hiding this comment

andrerom commented Aug 1, 2017

emodric commented Aug 1, 2017

andrerom commented Aug 1, 2017

emodric commented Aug 1, 2017

Plopix commented Aug 2, 2017

emodric commented Aug 2, 2017

andrerom commented Aug 16, 2017

glye left a comment

Choose a reason for hiding this comment

glye Aug 16, 2017

Choose a reason for hiding this comment

andrerom commented Jul 13, 2017 •

edited

Loading

andrerom commented Jul 13, 2017 •

edited

Loading

emodric commented Jul 13, 2017 •

edited

Loading