Add overriden NotFoundHttpException to have access to the original response #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
reviewed
May 4, 2017
| // we send an NotFoundHttpException to be able to trigger error page in Symfony stack. | ||
| if ($moduleResult['errorCode'] == 404) { | ||
| if ($this->notFoundHttpConversion) { | ||
| $errorMessage = isset($moduleResult['errorMessage']) ? $moduleResult['errorMessage'] : 'Not found'; | ||
| throw new NotFoundHttpException($errorMessage); | ||
| $exception = new NotFoundHttpException($errorMessage); |
There was a problem hiding this comment.
can't you use custom ctor given it is custom exception?
…sponse when converting 404
andrerom
approved these changes
May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #91 is done, it would greatly help to know what happened in legacy when a 404 error is received.
We have some siteaccesses that run in legacy mode set to false, but still display legacy 404 errors, so this would help facilitate that.
It is worthwhile to note that this behaviour (this custom 404 exception) would still be part of 2.0 release.