Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EZP-26389: EZP-26181 truncates uri_part #68

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Fix EZP-26389: EZP-26181 truncates uri_part #68

merged 1 commit into from
Oct 12, 2016

Conversation

wizhippo
Copy link
Contributor

@wizhippo wizhippo commented Oct 6, 2016 •
edited by glye
Loading

wizhippo referenced this pull request Oct 6, 2016
@glye
Fix EZP-26181: Content with same name as URL matcher will lead to bro…
d30373f 
…ken links (#133)

(cherry picked from kernel-ee commit 1e901d315912e5459c18b3d1de90b063a4c1d7e0)
glye
glye approved these changes Oct 7, 2016
View reviewed changes
Copy link
Member

@glye glye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thanks for the report and PR! I added issue EZP-26389 for it.

Nitpick: Commit message speling :) Please update to "Fix EZP-26389: EZP-26181 truncates uri_part"

@glye
Copy link
Member

glye commented Oct 7, 2016

Ping @joaoinacio @bdunogier @andrerom

@wizhippo wizhippo changed the title Fix uri_part trunication Fix EZP-26389: EZP-26181 truncates uri_part Oct 7, 2016
andrerom
andrerom approved these changes Oct 11, 2016
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, ideally with commit message fixes but we can potentially do that on merge.

@andrerom andrerom merged commit 373c6fd into ezsystems:master Oct 12, 2016
@wizhippo wizhippo deleted the fix_uri_part_trunc branch October 12, 2016 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom approved these changes

@glye glye glye approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wizhippo @glye @andrerom