EZP-28926: Add a legacy security voter decorator #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y modules/functions before exceptions are thrown
You mean netgen legacy admin or something? legacy extensions tend to use legacy api for this right? so not really affected or? |
|
Netgen legacy admin, yes, but really any custom code from the new stack checking for legacy permissions. We have some pages implemented in the frontend too which reuse pieces of legacy, while checking for legacy permissions too with permissions resolver. |
andrerom
approved these changes
Mar 22, 2018
kmadejski
approved these changes
Mar 26, 2018
| return true; | ||
| } | ||
|
|
||
| public function vote(TokenInterface $token, $object, array $attributes) |
There was a problem hiding this comment.
Would be nice to see PHPDocs here.
|
@kmadejski Added PHPDoc 👍 |
|
@andrerom OK to merge and tag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows checking for legacy modules/functions before exceptions are thrown.
It only rethrows the exception if for some reason this voter votes with
ACCESS_ABSTAIN.Needed for legacy permission checking after ezsystems/ezpublish-kernel#2273.