Always return location IDs from SwitchableHttpCachePurger::purge #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emodric
force-pushed
the
emodric-patch-1
branch
from
6ef3a5f to
5ca78a0
Compare
eZ Publish Legacy expects that `content/cache` events always return location IDs they were given (https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/classes/ezcontentcachemanager.php#L772). In eZ Publish kernel 6.x, there was an InstantCachePurger that did this (https://github.com/ezsystems/ezpublish-kernel/blob/6.13/eZ/Publish/Core/MVC/Symfony/Cache/Http/InstantCachePurger.php#L61-L66), but in 7.0 (and presumably with 6.x with new HttpCacheBundle turned on), this does not happen. So here, we make sure that location IDs are always returned, no matter what.
emodric
force-pushed
the
emodric-patch-1
branch
from
5ca78a0 to
350613b
Compare
andrerom
approved these changes
Dec 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes clearing view caches in legacy admin interface running in
legacy_mode: false, e.g. Netgen Admin UI.eZ Publish Legacy expects that
content/cacheevents always return locationIDs they were given (https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/classes/ezcontentcachemanager.php#L772).
In eZ Publish kernel 6.x, there was an InstantCachePurger that did this
(https://github.com/ezsystems/ezpublish-kernel/blob/6.13/eZ/Publish/Core/MVC/Symfony/Cache/Http/InstantCachePurger.php#L61-L66),
but in 7.0 (and presumably with 6.x with new HttpCacheBundle turned on),
this does not happen.
So here, we make sure that location IDs are always returned, no matter what.