Add 2.0 upgrade docs #128
Merged
Add 2.0 upgrade docs #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
reviewed
Dec 19, 2017
doc/upgrade/2.0.md
Outdated
| services from legacy bridge. | ||
|
|
||
| * Most of the services have been marked as private in Symfony DI container. | ||
| You should not fetch them from container directly any more, instead, inject |
There was a problem hiding this comment.
anymore? instead inject
andrerom
reviewed
Dec 19, 2017
doc/upgrade/2.0.md
Outdated
| You should not fetch them from container directly any more, instead, inject | ||
| them as constructor arguments into your services. | ||
|
|
||
| * HTTP 404 error conversion in legacy mode `false` siteaccesses is now turned |
There was a problem hiding this comment.
something like this might be easier to grasp:HTTP 404 error conversion when legacy mode is false in given siteaccesses is now always handled by Symfony, and config option to control this has been removed so the logic follows legacy mode setting. If you have ...
emodric
force-pushed
the
upgrade_docs
branch
from
3e7728f to
81f9df7
Compare
emodric
force-pushed
the
upgrade_docs
branch
from
81f9df7 to
716b9e5
Compare
|
@andrerom Fixed both nitpicks. |
|
And this one made the other PR much more clear (which is why dealing with dev doc in same PR as code is sometimes a good thing ;)) |
;) |
kmadejski
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents upgrading to 2.0, specifically:
#122
#126
#127