Add option to disable reorder on WEG and Toolbar: Feat(#412) #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eythaann
requested changes
Feb 2, 2025
| @@ -224,27 +225,27 @@ export function SeelenWeg() { | |||
| ); | |||
| } | |||
|
|
|||
| function ItemByType(item: SwItem, callback: (isOpen: boolean) => void) { | |||
| function ItemByType(item: SwItem, drag: boolean, callback: (isOpen: boolean) => void) { | |||
There was a problem hiding this comment.
drag doesn't need to be passed as property, instead disable it on Reorder.Group, remove this code.
There was a problem hiding this comment.
There is no such an option ^^
There was a problem hiding this comment.
I can do this:
If you wish to disable it on Reorder.Group, but this will has this side-effect:
Screen.Recording.2025-02-02.170348.mp4
There was a problem hiding this comment.
I make as shown by the video on the last commit. It is easily revertable.
There was a problem hiding this comment.
Eh sorry #533 (comment) missed my attention...
There was a problem hiding this comment.
theoretically this should work, but apparently it isn't, so let as it is.
Edit: as it was before, is just revert b4af1b5 I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependecy:
Seelen-Inc/slu-lib#10
Option requested (#412) in the context menu for the weg and the tb:
Ymls:
toolbar:
weg: