Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miri validation errors through now stricter provenance #103

Merged
merged 11 commits into from
Sep 19, 2023
Merged

Fix miri validation errors through now stricter provenance #103

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8c5cabb
fix(miri): box transmute and invalid references
ten3roberts Aug 23, 2023
3640ba8
fix(miri): downcast_mut using `&mut _ => *const _ => *mut`
ten3roberts Aug 23, 2023
4547d19
fix(miri): stub file reading
ten3roberts Aug 23, 2023
ae66514
fix(miri): don't construct temp references of shunk provenance
ten3roberts Aug 25, 2023
9a7426e
ci: miri
ten3roberts Aug 25, 2023
524a5a8
fix: `unsafe_op_in_unsafe_fn`
ten3roberts Sep 5, 2023
078a3c5
chore!: bump MSRV
ten3roberts Sep 5, 2023
81e88f5
chore: address PR comments
ten3roberts Sep 5, 2023
f04d9e9
fix: ci workflow names
ten3roberts Sep 16, 2023
3f529f4
chore: raise msrv to 1.65 (addr2line)
ten3roberts Sep 16, 2023
b5dd86a
chore: revert distinctive CI names due to branch protection rules
ten3roberts Sep 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:

name: Continuous integration

env:
MIRIFLAGS: -Zmiri-strict-provenance

jobs:
check:
name: Check
Expand Down Expand Up @@ -126,3 +129,17 @@ jobs:
with:
command: clippy
args: -- -D warnings
miri:
yaahc marked this conversation as resolved.
Show resolved Hide resolved
name: Miri
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions-rs/toolchain@v1
with:
toolchain: nightly
components: miri
override: true
- uses: actions-rs/cargo@v1
with:
command: miri
args: test
4 changes: 2 additions & 2 deletions src/context.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use crate::error::ContextError;
use crate::error::{ContextError, ErrorImpl};
use crate::{ContextCompat, Report, StdError, WrapErr};
use core::fmt::{self, Debug, Display, Write};

Expand Down Expand Up @@ -158,7 +158,7 @@ where
D: Display,
{
fn source(&self) -> Option<&(dyn StdError + 'static)> {
Some(self.error.inner.error())
Some(ErrorImpl::error(self.error.inner.as_ref()))
}
}

Expand Down
Loading