Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Date() #51

Closed
bhelx opened this issue Mar 1, 2024 · 2 comments · Fixed by #52
Closed

Add support for Date() #51

bhelx opened this issue Mar 1, 2024 · 2 comments · Fixed by #52

Comments

@bhelx
Copy link
Contributor

bhelx commented Mar 1, 2024

Add basic support for Date() for simple timing. Need to consider possibility of exposing too much timing information.
@ryanbethel
Copy link

Could it be opt-in with a flag? In my use case I only need it for some logging during development and debugging. So if it exposed vulnerability, I could disable it for production.

@bhelx
Copy link
Contributor Author

bhelx commented Mar 1, 2024

Yes, that might be a good compromise for the time being.

bhelx added a commit that referenced this issue Mar 1, 2024
@bhelx
feat: Add basic support for Date
80df74e 
Closes #51

The caveat is that the JS code doesn't know anything about your timezone
yet.
@bhelx bhelx mentioned this issue Mar 1, 2024
Merged
@bhelx bhelx closed this as completed in #52 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add basic support for Date extism/js-pdk
2 participants
@bhelx @ryanbethel