Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure we instantiate non-main modules #93

Merged
merged 11 commits into from
Jan 30, 2025
Merged

fix: make sure we instantiate non-main modules #93

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9525604
add test case that fails
mhmd-azeez Jan 15, 2025
b064e7d
fix: make sure we instantiate non-main modules
mhmd-azeez Jan 15, 2025
ddc6883
address PR feedback
mhmd-azeez Jan 16, 2025
403e560
can't instantiate multiple instances when we have linked modules
mhmd-azeez Jan 21, 2025
c8ad48d
only allow one module with empty name
mhmd-azeez Jan 21, 2025
88fb826
fix condition
mhmd-azeez Jan 21, 2025
1d744f0
fix: wrap the non-main modules in a host module to solve naming colli…
mhmd-azeez Jan 23, 2025
9114be4
Merge branch 'main' into fix_module_linking
mhmd-azeez Jan 23, 2025
444f573
fix build
mhmd-azeez Jan 23, 2025
439953c
add a zero
mhmd-azeez Jan 23, 2025
8acf488
Ensure the init func is invoked an all dependencies before main
evacchi Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a zero
  • Loading branch information
@mhmd-azeez
mhmd-azeez committed Jan 23, 2025
commit 439953ce9fb2bfaaa3bf8560a3941f62b0e8ca19
4 changes: 2 additions & 2 deletions extism_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,7 +1137,7 @@ func TestCompiledModuleMultipleInstances(t *testing.T) {
}

var wg sync.WaitGroup
numInstances := 30
numInstances := 300

// Create and test instances in parallel
for i := 0; i < numInstances; i++ {
Expand Down Expand Up @@ -1170,7 +1170,7 @@ func TestCompiledModuleMultipleInstances(t *testing.T) {

func TestMultipleCallsOutputParallel(t *testing.T) {
manifest := manifest("count_vowels.wasm")
numInstances := 30
numInstances := 300

var wg sync.WaitGroup

Expand Down
Loading