fix: return *Plugin from NewPlugin to keep a consistent pointer #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmd-azeez
approved these changes
Aug 1, 2023
mhmd-azeez
added a commit
that referenced
this pull request
Aug 3, 2023
* copied the source code from extism-wasm-runtime and added a couple of examples * feat: add support for manifests * feat: select a main module for each module and implement ToWasmData() for WasmUrl and WasmFile * feat: allow additional functions to be defined in env module * cleanup: config_get * cleanup: add wrap function to reduce boilerplate for kernel functions * implement var_get and var_set * feat: implement extism_var_set, extism_http_request, and extism_http_status_code * fix: add glob package to go.mod file * fix: AllowedPaths are file paths, not http paths * fix: limit response body size * compile config.wasm * update config.wasm * feat: implement an initial version of host functions * add todo for host function userdata * feat: implement logging support * feat: implement AllowedPaths * feat: Enable adding custom host functions in the `env` module (#4) * feat: allow defining host functions in the `env` package * feat: implement AllowedPaths * Revert "feat: implement AllowedPaths" This reverts commit ec639f0. * feat: implement runtime initialization logic * add a plugin for testing timeout and cleanup up some stuff * cleaned up some logs * fix: deny all requests by default * feat: turn examples into automated tests * fix: pass ctx when creating an http request * fix: change fs example to use do everything in main function * feat: check for Reactor modules * refactor runtime * fix: add proper support for Reactors * fix: fix a couple of bugs regarding exit codes and logging * fix: return *Plugin from NewPlugin to keep a consistent pointer to the Plugin (#6) * fix: remove *Plugin parameter from log methods and make sure haskell runtime is initialized and cleaned up * feat: add doc comments and slightly adjust the APIs * test: add test cases for WasmUrl and Hashing * test: bring over some test cases from the current go SDK * ci: add a workflow for CI * feat: expose memory functions on CurrentPlugin * docs: write a better README * ci: run tests on ubuntu, macos, and windows --------- Co-authored-by: zach <[email protected]> Co-authored-by: zach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.