Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change host function API and hide GuestRuntime #13

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

mhmd-azeez
Copy link
Collaborator

I wanted to change these before hitting 1.0 for the go-sdk:

  • I think we should hide HostFunction creation behind a function so that we have flexibility of adding new function callbacks in the future
  • And I think GuestRuntime is an implementation detail and doesn't need to be public

@mhmd-azeez mhmd-azeez requested review from bhelx and nilslice August 16, 2023 09:24
@mhmd-azeez
Copy link
Collaborator Author

@zshipko @bhelx @nilslice will merge this PR if no one has any objections

@nilslice
Copy link
Member

I think this looks great -- will wait for one other review though.. someone a little closer to the previous Host Functions impl would be ideal!

Copy link
Contributor

@zshipko zshipko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mhmd-azeez
Copy link
Collaborator Author

cc @k33g you might need to update your demo for your talk

@mhmd-azeez mhmd-azeez merged commit afbb83e into main Aug 29, 2023
@mhmd-azeez mhmd-azeez deleted the refactor-api branch August 29, 2023 14:33
@k33g
Copy link
Collaborator

k33g commented Aug 29, 2023

@mhmd-azeez thanks for the notification, I will have a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants