New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: seperate implementation from interface #17

Merged

G4Vi merged 2 commits into main from feat-seperate-implementation

Dec 18, 2023

Contributor

G4Vi commented Dec 18, 2023

Resolves #12

Separated implementation from interface. It's still a single header library, but one compilation unit must #define EXTISM_IMPLEMENTATION before including extism-pdk.h
C++ compat. Implementation still must be built with a C compiler, but it's the C pdk is now usable from C++.
Added BUILDING section to README to cover EXTISM_IMPLEMENTATION, EXTISM_USE_LIBC and building with C++.
Add extism_log_sz

G4Vi added 2 commits

December 18, 2023 17:45


          feat: seperate interface from implementation, cplusplus compat

3bcaa9e


          feat: extism_log_sz

110ec4c

G4Vi requested a review from zshipko

December 18, 2023 22:59

G4Vi changed the title ~~Feat: seperate implementation from nterface~~ Feat: seperate implementation from interface

zshipko approved these changes

View reviewed changes

Contributor

zshipko left a comment

Looks good, thanks!

G4Vi merged commit 01064c0 into main

2 checks passed

G4Vi deleted the feat-seperate-implementation branch

December 18, 2023 23:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet