-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcing the exported extendr_wrappers.R #7
Sourcing the exported extendr_wrappers.R #7
Conversation
This makes use of extendr#40.
This test needs to be reworked for every setup..
Doesn't this remove the need for all of this file: https://github.com/clauswilke/rextendr/blob/main/R/exported_functions.R Also, with this PR we should make @hobofan a coauthor. His contribution is to remove 56 lines of code. |
And please don't add a test that cannot work because it looks for files only available on your hard drive. I had purposefully not added a test yet because it won't work until the various required crates are updated on crates.io. You can leave the code there but disable the test, or delete the test. |
Co-authored-by: hobofan <[email protected]>
@CGMossa Could you merge in the current main branch and check that this PR still works? |
Do you want me to press the squash and merge button or do you want me to pull from main and then push that pull onto this PR? |
…_macro_exported_r_interface
I wanted you to do exactly what you just did. :-) |
Oh, but also try locally whether the resulting package still works. E.g., can you knit the vignette available here: |
Alright, I'm having some issues:
This got fixed after I changed Anyways, after this, the rmarkdown knits and everything works. |
Thanks! |
* Sourcing the exported extendr_wrappers.R This makes use of extendr#40. * Added a test This test needs to be reworked for every setup.. * Removed wrapper function code. Co-authored-by: hobofan <[email protected]> * Skipping machine specific test Co-authored-by: hobofan <[email protected]>
This makes use of pull-request #40 on extendr/extendr.