Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updated scorecard actions #6322

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

Phillip9587
Copy link
Contributor

CI is still failing after #6314 because the scorecard workflow also uses the deprecated v3 version of actions/upload-artifact. I updated all commit shas of the scorecard workflow to their latest versions.

@Phillip9587
Copy link
Contributor Author

Hey @UlisesGascon, can we maybe fast-track this PR because the master branch checks are failing because of the scorecard workflow?

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the commits against the source repos, not that I don't trust you, but this is what we all need to do when we merge PRs like this to ensure the commits come from the source repo and not a fork.

@wesleytodd
Copy link
Member

I agree seems like we can fast track. Merging now.

@wesleytodd wesleytodd merged commit ae6a462 into expressjs:master Feb 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants