Fix OpDivide: change resulting type to float64 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentrax
changed the title
|
Nice. But please update generator of helpers. |
Dentrax
force-pushed
the
divide-float64
branch
from
f12a345 to
1ed2514
Compare
|
Ah, sure boss! Didn't notice it! Now it's done. |
antonmedv
requested changes
Nov 4, 2022
Fixes expr-lang#270 Signed-off-by: Furkan <[email protected]>
Dentrax
force-pushed
the
divide-float64
branch
from
1ed2514 to
cedb958
Compare
antonmedv
approved these changes
Nov 4, 2022
|
Gonna fix tests on my own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #270
Signed-off-by: Furkan [email protected]
Added all possible
/tests for different types, and it's working as expected now. Also I had to addruntime.ToFloat64()forOpDivide, otherwise it rounds up the value and convertsfloat32. For example:-is wrong,+is correct value (withruntime.ToFloat64).cc @antonmedv