[cli] Improve Snack support for older SDKs #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/improve-snack-multi-sdk-support
branch
from
2a59b87 to
2233b0f
Compare
gabrieldonadel
commented
Jan 2, 2024
| 'packages', | ||
| EXPO_GO_BUNDLE_IDENTIFIER | ||
| ); | ||
| export async function isAppInstalledOnEmulatorAsync( |
There was a problem hiding this comment.
This will be handy when we add support for opening updates
gabrieldonadel
commented
Jan 2, 2024
Comment on lines
+277
to
+285
| const localPath = await getContainerPathAsync({ | ||
| udid, | ||
| bundleIdentifier: EXPO_GO_BUNDLE_IDENTIFIER, | ||
| }); | ||
| if (!localPath) { | ||
| return null; | ||
| } | ||
|
|
||
| const regex = /Exponent-([0-9.]+).*\.app$/; | ||
| const regexMatch = regex.exec(localPath); | ||
| if (!regexMatch) { | ||
| return null; | ||
| } | ||
| const builtInfoPlistPath = path.join(localPath, 'EXSDKVersions.plist'); |
There was a problem hiding this comment.
Unfortunately this is only possible on simulators, I tried using the HouseArrest Service to retrieve the EXSDKVersions on a real device but that doesn't work either given that VendContainer is only supported on dev-signed apps
alanjhughes
approved these changes
Jan 2, 2024
gabrieldonadel
deleted the
@gabrieldonadel/improve-snack-multi-sdk-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-10972
How
Improve Snack support for older SDKs on iOS and Android
on iOS Simulators:
EXSDKVersions.pliston iOS Real devices:
EXSDKVersions.plist(even through HouseArrest) and we can't install specific versions of Expo Goon Android:
EXSDKVersions.pliston Android so we need to rely on checking the app version against the latest expo go release for a given SDK, reading from API V2 versions/latest. If the opened Snack requires a downgrade of Expo Go, first uninstall the app to avoidINSTALL_FAILED_VERSION_DOWNGRADETest Plan
Screen.Recording.2024-01-02.at.14.41.021.mov