Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add appBuildVersion to build metadata #413

Merged
merged 6 commits into from
May 20, 2021
Merged

add appBuildVersion to build metadata #413

merged 6 commits into from
May 20, 2021

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented May 19, 2021

Checklist

Why

@jonsamp asked to add Android version code and iOS build number to build metadata.

How

  • appBuildVersion
    • iOS
      • generic projects: CFBundleVersion in Info.plist
      • managed projects: ios.buildNumber in app config
    • Android
      • generic projects: versionCode in build.gradle
      • managed projects: android.versionCode in app config
  • I also changed how version is resolved. Previously, it was always version from the app config. It wasn't correct for generic projects.
    • managed projects: version in app config
    • generic projects:
      • android: versionName in build.gradle
      • ios: CFBundleShortVersionString in Info.plist

Test Plan

  • Added some unit tests
  • Ran android and ios builds and verified that correct metadata have been sent to www.

@github-actions
Copy link

github-actions bot commented May 19, 2021

Size Change: +433 B (0%)

Total Size: 31.7 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 31.7 MB +433 B (0%)

compressed-size-action

@dsokal dsokal requested a review from wkozyra95 May 19, 2021 12:09
@dsokal dsokal changed the title @dsokal/versions add buildNumber and versionCode to build metadata May 19, 2021
@dsokal dsokal marked this pull request as ready for review May 19, 2021 12:09
@dsokal dsokal force-pushed the @dsokal/versions branch from b66a068 to ed57f7e Compare May 20, 2021 09:33
@dsokal dsokal force-pushed the @dsokal/versions branch from ed57f7e to 153fbc6 Compare May 20, 2021 09:35
@dsokal dsokal changed the title add buildNumber and versionCode to build metadata add appBuildVersion to build metadata May 20, 2021
@dsokal dsokal merged commit 47d21de into main May 20, 2021
@dsokal dsokal deleted the @dsokal/versions branch May 20, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants