Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use lowercase commands descriptions #2907

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Feb 14, 2025

Why

https://exponent-internal.slack.com/archives/C017N0N99RA/p1739495318680849

How

use lowercase commands descriptions

Test Plan

run locally

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review February 14, 2025 17:14
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

Size Change: -384 B (0%)

Total Size: 53.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.5 MB -384 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.65%. Comparing base (d7e48c2) to head (e2318c4).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2907   +/-   ##
=======================================
  Coverage   52.65%   52.65%           
=======================================
  Files         588      588           
  Lines       23193    23193           
  Branches     4857     4857           
=======================================
  Hits        12210    12210           
  Misses      10016    10016           
  Partials      967      967           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label Feb 27, 2025
@szdziedzic szdziedzic merged commit 2790fd4 into main Feb 27, 2025
12 of 13 checks passed
@szdziedzic szdziedzic deleted the 02-14-use_lowercase_commands_descriptions branch February 27, 2025 09:18
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants