-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] popup website in fingerprint:compare #2859
[eas-cli] popup website in fingerprint:compare #2859
Conversation
Size Change: +2.35 kB (0%) Total Size: 53.4 MB
|
Subscribed to pull request
Generated by CodeMention |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2859 +/- ##
==========================================
- Coverage 52.41% 52.39% -0.01%
==========================================
Files 589 589
Lines 23110 23118 +8
Branches 4838 4839 +1
==========================================
+ Hits 12110 12111 +1
- Misses 10034 10040 +6
- Partials 966 967 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change.
Co-authored-by: Will Schurman <[email protected]>
✅ Thank you for adding the changelog entry! |
Why
When comparing fingerprints diffs in the CLI, popup the website window for a better viewing experience in interactive mode.
Screen.Recording.2025-02-03.at.1.37.19.PM.mov
How
Added functionality to automatically open the web-based fingerprint comparison tool in the browser after displaying the CLI output. This provides users with a more comprehensive and interactive way to analyze differences between fingerprints.
The browser only opens when running in interactive mode, preserving the existing behavior for CI/CD environments.
Test Plan
fingerprint:compare
with differing hashes