Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] popup website in fingerprint:compare #2859

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Feb 3, 2025

Why

When comparing fingerprints diffs in the CLI, popup the website window for a better viewing experience in interactive mode.

Screen.Recording.2025-02-03.at.1.37.19.PM.mov

How

Added functionality to automatically open the web-based fingerprint comparison tool in the browser after displaying the CLI output. This provides users with a more comprehensive and interactive way to analyze differences between fingerprints.

The browser only opens when running in interactive mode, preserving the existing behavior for CI/CD environments.

Test Plan

  • ran fingerprint:compare with differing hashes

Copy link
Member Author

quinlanj commented Feb 3, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Feb 3, 2025

Size Change: +2.35 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +2.35 kB (0%)

compressed-size-action

@quinlanj quinlanj marked this pull request as ready for review February 3, 2025 21:53
Copy link

github-actions bot commented Feb 3, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.39%. Comparing base (608d61e) to head (1ad3b47).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/eas-cli/src/commands/fingerprint/compare.ts 12.50% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2859      +/-   ##
==========================================
- Coverage   52.41%   52.39%   -0.01%     
==========================================
  Files         589      589              
  Lines       23110    23118       +8     
  Branches     4838     4839       +1     
==========================================
+ Hits        12110    12111       +1     
- Misses      10034    10040       +6     
- Partials      966      967       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change.

Copy link

github-actions bot commented Feb 3, 2025

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit 7f46bae into main Feb 3, 2025
11 checks passed
@quinlanj quinlanj deleted the 02-03-_eas-cli_popup_website_in_fingerprint_compare branch February 3, 2025 23:47
quinlanj added a commit that referenced this pull request Feb 4, 2025
quinlanj added a commit that referenced this pull request Feb 4, 2025
quinlanj added a commit that referenced this pull request Feb 4, 2025
quinlanj added a commit that referenced this pull request Feb 4, 2025
* Reapply "[eas-cli] popup website in fingerprint:compare (#2859)" (#2862)

This reverts commit 528988d.

* Temporary Commit at 2/4/2025, 11:36:07 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants