[eas-cli] skip creation of testflight group when there are already exisitng testflight groups + allow to opt out of the behavior by setting env var #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Subscribed to pull request
Generated by CodeMention |
|
Size Change: +1.04 kB (0%) Total Size: 53.5 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
==========================================
- Coverage 52.65% 52.63% -0.01%
==========================================
Files 588 588
Lines 23193 23200 +7
Branches 4857 4859 +2
==========================================
Hits 12210 12210
- Misses 10016 10021 +5
- Partials 967 969 +2 ☔ View full report in Codecov by Sentry. |
kadikraman
approved these changes
Feb 3, 2025
| }: { | ||
| groups: BetaGroup[]; | ||
| app: App; | ||
| }): Promise<BetaGroup> { | ||
| let betaGroup = groups.find(group => group.attributes.name === AUTO_GROUP_NAME); | ||
| if (!betaGroup) { |
There was a problem hiding this comment.
This check is now redundant so could be a regular try / catch
There was a problem hiding this comment.
why is it redundant? I'm not sure I see it
There was a problem hiding this comment.
I'm not sure what I meant there 😅 - nevermind me.
EvanBacon
reviewed
Feb 3, 2025
packages/eas-cli/src/credentials/ios/appstore/ensureTestFlightGroup.ts
Outdated
Show resolved
Hide resolved
…isitng testflight groups + allow to opt out of the behavior by setting env var
szdziedzic
force-pushed
the
02-03-_eas-cli_skip_creation_of_testflight_group_when_there_are_already_exisitng_testflight_groups_allow_to_opt_out_of_the_behavior_by_setting_env_var
branch
from
e1f9794 to
373c8b4
Compare
kadikraman
approved these changes
Feb 20, 2025
|
✅ Thank you for adding the changelog entry! |
szdziedzic
deleted the
02-03-_eas-cli_skip_creation_of_testflight_group_when_there_are_already_exisitng_testflight_groups_allow_to_opt_out_of_the_behavior_by_setting_env_var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://exponent-internal.slack.com/archives/C014YHUJUMN/p1738577486565949?thread_ts=1738574914.864689&cid=C014YHUJUMN
How
If there are any existing testflight groups skip the creation of the
Team (Expo)group.Allow to opt out of the creation y setting
EXPO_SKIP_TESTFLIGHT_SETUP=1Test Plan
Tests