[eas-json] [ENG-14636] Allow longer submit profile extension chains #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended the limit for expansion chain for submit profiles to equal that of build profiles - 5 See: https://linear.app/expo/issue/ENG-14636/allow-longer-profile-extend-chains-in-easjson
Added tests for submit profiles extension chain See: https://linear.app/expo/issue/ENG-14636/allow-longer-profile-extend-chains-in-easjson
Added tests for build profiles extension chain See: https://linear.app/expo/issue/ENG-14636/allow-longer-profile-extend-chains-in-easjson
|
Subscribed to pull request
Generated by CodeMention |
|
Size Change: -1.25 kB (0%) Total Size: 53.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2831 +/- ##
==========================================
+ Coverage 52.59% 52.62% +0.03%
==========================================
Files 584 584
Lines 22638 22638
Branches 4467 4467
==========================================
+ Hits 11905 11910 +5
+ Misses 10699 10694 -5
Partials 34 34 ☔ View full report in Codecov by Sentry. |
3 tasks
szdziedzic
approved these changes
Jan 22, 2025
…-14636_allow_longer_profile_extension_chains
|
✅ Thank you for adding the changelog entry! |
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-14636_allow_longer_profile_extension_chains
branch
radoslawkrzemien
added a commit
to expo/expo
that referenced
this pull request
Jan 22, 2025
# Why https://linear.app/expo/issue/ENG-14636/allow-longer-profile-extend-chains-in-easjson expo/eas-cli#2793 A user complained that the max profile extension chain length is different for build and submit profiles, and for neither the limit is mentioned in the docs Companion to: expo/eas-cli#2831 # How Updated the maximal length of extension chain for submit profile to 5, which makes it the same as for build profiles. Updated the docs regarding the max length of the profile extension chain. # Test Plan Tested manually Build Profile | Before | After | | - | - | | <img width="1104" alt="Screenshot 2025-01-21 at 14 51 35" src="https://github.com/user-attachments/assets/7a14f4b6-268c-4b39-aea0-7a2b0eff26ce" /> | <img width="1104" alt="Screenshot 2025-01-21 at 14 50 50" src="https://github.com/user-attachments/assets/6c784725-2874-4389-ad39-54da0fc399fe" /> | Submit Profile | Before | After | | - | - | | <img width="1104" alt="Screenshot 2025-01-21 at 14 51 46" src="https://github.com/user-attachments/assets/0b03326b-5e35-4bef-b2f7-239285c342b4" /> | <img width="1104" alt="Screenshot 2025-01-21 at 14 51 16" src="https://github.com/user-attachments/assets/2c7aa570-1299-40da-aa98-3f57f82f4590" /> | # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-14636/allow-longer-profile-extend-chains-in-easjson
Submit profile extension chain limit is smaller than for build profiles so the user has issues when setting up submit and build profiles in the same way
How
Increased the submit profile extension chain to equal that for build profiles - 5 instead of 2.
Test Plan
Added tests for chaining extensions, up to 5 and above, for submit and build profiles