Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] make version/CFBundleShortVersionString validation logic show warn instead of throwing an error #2741

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Dec 5, 2024

Why

#2733

How

Show a warning instead of throwing an error when validating the version/CFBundleShortVersionString

Test Plan

Tests

Copy link
Member Author

Copy link

github-actions bot commented Dec 5, 2024

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Dec 5, 2024

Size Change: +1.44 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +1.44 kB (0%)

compressed-size-action

@szdziedzic szdziedzic force-pushed the 12-05-_eas-cli_make_version_cfbundleshortversionstring_validation_logic_show_warn_instead_of_throwing_an_error branch from b7f997e to c41ad63 Compare December 6, 2024 12:35
Copy link

github-actions bot commented Dec 6, 2024

✅ Thank you for adding the changelog entry!

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (19973bb) to head (c41ad63).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/ios/version.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2741      +/-   ##
==========================================
- Coverage   52.51%   52.49%   -0.01%     
==========================================
  Files         583      583              
  Lines       22556    22556              
  Branches     4438     4438              
==========================================
- Hits        11842    11839       -3     
- Misses      10679    10682       +3     
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic merged commit 8d686b8 into main Dec 6, 2024
11 checks passed
@szdziedzic szdziedzic deleted the 12-05-_eas-cli_make_version_cfbundleshortversionstring_validation_logic_show_warn_instead_of_throwing_an_error branch December 6, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants