Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Revert "[1/1][eas-cli] generate eas-update-metadata.json on publish … #2187

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

quinlanj
Copy link
Member

…(#2158)"

This reverts commit 183fe87.

Why

Sorry for flip-flopping, but it turns out I didn't need to output eas update metadata to a separate file for the sentry/eas-update integration work we were doing, so no one needs it anymore.

Test Plan

  • tests still pass

Copy link

github-actions bot commented Jan 18, 2024

Size Change: +78 B (0%)

Total Size: 50.2 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 50.2 MB +78 B (0%)

compressed-size-action

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9064b7) 54.11% compared to head (7da5473) 54.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2187      +/-   ##
==========================================
- Coverage   54.11%   54.09%   -0.01%     
==========================================
  Files         516      516              
  Lines       18815    18809       -6     
  Branches     3771     3770       -1     
==========================================
- Hits        10179    10172       -7     
- Misses       8615     8616       +1     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj
Copy link
Member Author

/changelog-entry breaking-change stop generating eas-update-metadata.json on publish

@quinlanj quinlanj removed the request for review from EvanBacon January 18, 2024 04:07
Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit 41142a9 into main Jan 18, 2024
9 checks passed
@quinlanj quinlanj deleted the @quin/revert-stuff branch January 18, 2024 21:59
@rainst
Copy link
Contributor

rainst commented Jul 4, 2024

hi @quinlanj,
currently Bugsnag doesn't support automatic source map upload after running eas update so I made a script that makes a manual submission after an update. The script is relying on dist/eas-update-metadata.json to obtain the bundle ids.

I am currently using [email protected] and it works perfectly, but I realised that this feature was removed with the v7 release, is it possible to add it back since this is holding me back from updating?

thank you :)

rainst added a commit to rainst/eas-cli that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants