Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] use branch mapping utility fn #2186

Merged
merged 3 commits into from
Jan 18, 2024
Merged

[eas-cli] use branch mapping utility fn #2186

merged 3 commits into from
Jan 18, 2024

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jan 18, 2024

Why

Fix a TODO in the codebase to move branch mapping logic to utility function

Test Plan

  • tests still pass
  • manually sanity tested

Copy link

github-actions bot commented Jan 18, 2024

Size Change: -4.72 kB (0%)

Total Size: 51.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.5 MB -4.72 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9064b7) 54.11% compared to head (dd43df6) 54.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2186   +/-   ##
=======================================
  Coverage   54.11%   54.11%           
=======================================
  Files         516      516           
  Lines       18815    18815           
  Branches     3771     3771           
=======================================
  Hits        10179    10179           
  Misses       8615     8615           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quinlanj
Copy link
Member Author

/changelog-entry chore use branch mapping utility fn

@quinlanj quinlanj merged commit 72c28d4 into main Jan 18, 2024
5 checks passed
@quinlanj quinlanj deleted the @quin/fix-todo branch January 18, 2024 21:58
Copy link

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants