-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-11076][eas-cli] prompt user to map channel on update if unmapped #2185
Conversation
Size Change: -365 B (0%) Total Size: 50.2 MB
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
==========================================
+ Coverage 54.11% 54.12% +0.02%
==========================================
Files 516 516
Lines 18815 18822 +7
Branches 3771 3771
==========================================
+ Hits 10179 10185 +6
- Misses 8615 8616 +1
Partials 21 21 ☔ View full report in Codecov by Sentry. |
/changelog-entry chore prompt user to map channel on update if unmapped |
✅ Thank you for adding the changelog entry! |
It feels awkward to me that we allow creating an update with just a channel flag since updates are associated with branches instead of channels. I assume the channel flag was added as a convenience flag for singly-mapped channel-branch combinations? edit: PR that added it makes it seem like this behavior might have been intentional: #1567 |
I guess my other worry is that this might be too heavy of an operation for people to comprehend what is being done. By pointing an existing channel at an existing branch, any other/existing builds with that channel will now receive compatible updates on that branch. I worry that people running a simple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes for now to put it back in your queue to assess.
@wschurman you raise a really good point in #2185 (comment) . People will have to select a branch to map to a channel (they don't reply Closing this PR to retain the original behaviour. |
Why
When an update is created with the
channel
flag, it will error if the channel is not mapped to a branch.This PR allows the user to select the branch to map in this case:
Test Plan