-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-11090][eas-cli] prompt users if they want to continue if provisioning the devices fails #2181
[ENG-11090][eas-cli] prompt users if they want to continue if provisioning the devices fails #2181
Conversation
/changelog-entry chore Prompt users if they want to continue if EAS CLI fails to provision the devices |
Size Change: +1.63 kB (0%) Total Size: 55.5 MB
|
c7ffe59
to
efa6c34
Compare
✅ Thank you for adding the changelog entry! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2181 +/- ##
==========================================
+ Coverage 54.23% 54.23% +0.01%
==========================================
Files 509 509
Lines 18660 18664 +4
Branches 3737 3738 +1
==========================================
+ Hits 10118 10121 +3
- Misses 8521 8522 +1
Partials 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
Why
https://linear.app/expo/issue/ENG-11090/prompt-user-whether-they-want-to-continue-if-we-fail-to-provision
How
Prompt users if they want to continue if we fail to provision the devices
Test Plan
(Yeah I know it says 0, I commented out the if statement to test it)

