Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for CBlas changes in Thinc 8.1.0.dev2 #21

Merged
merged 1 commit into from
Jun 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cython>=0.25
numpy>=1.21.0
thinc>=8.1.0.dev0,<9.0.0
thinc>=8.1.0.dev2,<9.0.0
# dev
pytest>=5.2.0
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ include_package_data = true
python_requires = >=3.6
install_requires =
numpy>=1.21.0
thinc>=8.1.0.dev0,<9.0.0
thinc>=8.1.0.dev2,<9.0.0

[options.entry_points]
thinc_ops =
Expand Down
6 changes: 3 additions & 3 deletions thinc_apple_ops/ops.pyx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Optional
import numpy
from thinc.backends.cblas cimport CBlas
from thinc.backends.cblas cimport CBlas, set_saxpy, set_sgemm
from thinc.backends.numpy_ops import NumpyOps
from thinc.types import Floats2d
from . import blas
Expand All @@ -15,8 +15,8 @@ class AppleOps(NumpyOps):

def cblas(self) -> CBlas:
cdef CBlas cblas = CBlas()
cblas.set_saxpy(saxpy)
cblas.set_sgemm(sgemm)
set_saxpy(cblas, saxpy)
set_sgemm(cblas, sgemm)
return cblas

def gemm(
Expand Down