Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance to handle binary files in git in Windows #2526

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

alexvy86
Copy link
Contributor

@alexvy86 alexvy86 commented Jul 6, 2018

Description

Adds guidance on what to do if users encounter the error described in 1634, which probably only happens in Windows environments.

Types of change

Change to documentation.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

Since this is purely a documentation change I didn't run the project tests.

Adds guidance on what to do if users encounter the error described in [1634](explosion#1634), which probably only happens in Windows environments.
@ines ines added the docs Documentation and website label Jul 8, 2018
@honnibal
Copy link
Member

honnibal commented Jul 9, 2018

Really appreciate this! I don't think I would've been able to figure out what the problem was.

@alexvy86
Copy link
Contributor Author

alexvy86 commented Jul 9, 2018

Happy to help :)

@ines
Copy link
Member

ines commented Jul 9, 2018

Thanks, this is super nice – always really appreciate contributions to the docs 🙏

@ines ines merged commit bd35bf7 into explosion:master Jul 9, 2018
grivaz pushed a commit to grivaz/spaCy that referenced this pull request Jul 18, 2018
Adds guidance on what to do if users encounter the error described in [1634](explosion#1634), which probably only happens in Windows environments.
cjhurst pushed a commit to cjhurst/spaCy that referenced this pull request Jul 24, 2018
Adds guidance on what to do if users encounter the error described in [1634](explosion#1634), which probably only happens in Windows environments.
@alexvy86 alexvy86 deleted the patch-3 branch April 20, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation and website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants