-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental coref docs #11291
Add experimental coref docs #11291
Conversation
It shouldn't list any spaCy version yet, until we actually port it over from experimental. |
Are we sure we want to put this in the main docs? There's no explanation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good idea to move this to a new PR for clarity :-)
Had a few more minor comments.
Co-authored-by: Sofie Van Landeghem <[email protected]>
It seems a period after a number made this think it was a list?
I think it would be okay to redefine the |
In that case what should we do for features like rehearsal, that can't be split out into |
That is a good point. I think having two separate |
How about we:
I think the point of the While it is true that it can be confusing if someone misses the note that an experimental feature is in a separate package, I think that's the kind of temporary confusion that's easily fixed, rather than something more serious like breaking an existing application. If we're diligent about signposting things that require the extra library, then I think the small chance of confusion is a fair tradeoff for the benefit of having the docs all in one place with consistent formatting (and being searchable too). |
I'll put this in draft state until explosion/spacy-experimental#17 has been merged. |
There won't be a "new" tag until it's in core.
Test failure here is due to python/mypy#13627. Since this PR contains no code, only docs, it should be safe to ignore. |
These weren't properly updated when the code was moved out of spacy core.
It looks like this hadn't actually been updated to make sure the sample code worked since the implementation moved to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found two more outdated spots:
* Add experimental coref docs * Docs cleanup * Apply suggestions from code review Co-authored-by: Sofie Van Landeghem <[email protected]> * Apply changes from code review * Fix prettier formatting It seems a period after a number made this think it was a list? * Update docs on examples for initialize * Add docs for coref scorers * Remove 3.4 notes from coref There won't be a "new" tag until it's in core. * Add docs for span cleaner * Fix docs * Fix docs to match spacy-experimental These weren't properly updated when the code was moved out of spacy core. * More doc fixes * Formatting * Update architectures * Fix links * Fix another link Co-authored-by: Sofie Van Landeghem <[email protected]> Co-authored-by: svlandeg <[email protected]>
Description
This PR includes just the docs written in #7264, which now cover the components in explosion/spacy-experimental#17. #7264 can be closed in favor of this PR.
This should not be merged before explosion/spacy-experimental#17.
One question is what version should be listed for the introduction of these components; currently it's 3.4.
(A few unrelated lines in the architecture docs were modified by prettier.)
Types of change
docs update
Checklist