Fixed an issue where non-ASCII characters were changed to Unicode characters within the prompt #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Youngrok123
commented
Oct 14, 2024
Youngrok123
commented
- There is an issue where non-ASCII characters are converted to Unicode characters within the prompt.
- Due to this issue, Users that use non-English characters will receive an abnormal response when communicating with LLM.
- This issue can be resolved by adding the ensure_ascii=False option when using the json.dumps function.
…racters within the prompt
dosubot
bot
added
the
size:XS
dosubot
bot
added
size:XXL
dosubot
bot
added
size:XS
|
hey @Youngrok123 thanks a lot for this fix - I will merge this in and release this with v0.1 as well but with v0.2 it will be in the https://docs.ragas.io/en/latest/references/prompt/#ragas.prompt.PydanticPrompt so I'll make the changes for that too |
jjmachan
pushed a commit
to jjmachan/ragas
that referenced
this pull request
Oct 14, 2024
…racters within the prompt (explodinggradients#1490) - There is an issue where non-ASCII characters are converted to Unicode characters within the prompt. - Due to this issue, Users that use non-English characters will receive an abnormal response when communicating with LLM. - This issue can be resolved by adding the ensure_ascii=False option when using the json.dumps function.
|
@Youngrok123 also created something for v0.2 prompts #1494 do let me know if there is any mistakes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.