New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-asii characters support in faithfulness #1396

Merged

shahules786 merged 1 commit into explodinggradients:main from gargewp:feature/cyrillic_support

Oct 1, 2024

Contributor

gargewp commented Oct 1, 2024

There is a bug with json.dumps: non-ascii charecters are converting into non-readable symbols.

It affects Faithfulness and NoiseSensitivity only.


          non-asii characters support in faithfulness

5a62023

dosubot bot added the size:XS label

shahules786 self-requested a review

October 1, 2024 10:33

shahules786 approved these changes

View reviewed changes

Member

shahules786 left a comment

Nice one @gargewp , thanks for the PR

shahules786 merged commit 053f74e into explodinggradients:main

16 checks passed

shahules786 pushed a commit to shahules786/ragas that referenced this pull request


          non-asii characters support in faithfulness (explodinggradients#1396)

2acea9a

There is a bug with json.dumps: non-ascii charecters are converting into
non-readable symbols.

It affects Faithfulness and NoiseSensitivity only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS