feat: output new Testset object for generation #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jjmachan
commented
Sep 30, 2024
•
jjmachan
commented
dosubot
bot
added
the
size:M
dosubot
bot
added
size:L
shahules786
requested changes
Sep 30, 2024
| @@ -80,21 +80,21 @@ def generate_with_langchain_docs( | |||
| def generate( | |||
| self, | |||
| test_size: int, | |||
| scenarios: t.Optional[QuestionTypes] = None, | |||
| simulators: t.Optional[QuestionTypes] = None, | |||
There was a problem hiding this comment.
Also here, if it's a simulator what is then QuestionTypes?
There was a problem hiding this comment.
changed this to simulator_distributions - how does that sound? is it clear?
shahules786
approved these changes
Oct 1, 2024
shahules786
pushed a commit
to shahules786/ragas
that referenced
this pull request
Oct 1, 2024
shahules786
pushed a commit
to shahules786/ragas
that referenced
this pull request
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.