Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some files can break the module. #10

Closed
bogado opened this issue Jun 17, 2017 · 2 comments
Closed

Some files can break the module. #10

bogado opened this issue Jun 17, 2017 · 2 comments

Comments

@bogado
Copy link
Contributor

bogado commented Jun 17, 2017

The gem will choke if there's a field that has "Date" in it's key but is either not a Date or an invalid date.

Example :
"GPSDateTime": "0111:00:30 20:31:58Z" From Nexus S
bogado added a commit to bogado/exiftool.rb that referenced this issue Jun 17, 2017
@bogado
Issue exiftool-rb#10: check if the value can be converted.
394ff53 
check if the value is convertable to a civil date before actually doing
the conversion.
@mceachen
Copy link
Member

Thanks for the diff and the bug report.

Is that from an image you have? Was it taken in 2011?

mceachen added a commit that referenced this issue Jun 19, 2017
@mceachen
add breaking test for #10
0ba89e0
@mceachen
Copy link
Member

Pushed v1.2.0 with a breaking test and your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bogado @mceachen