Add mentoring notes for leap in R #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqa236
reviewed
Mar 13, 2019
| ### Common suggestions | ||
| - there are just two cases that return True: | ||
| - a year is a multiple of 4 *and not* 100 | ||
| - a year is a multiple of 4, 100, and 400 |
There was a problem hiding this comment.
I think the second condition should be "a year is a multiple of 400". Clearly it will be a multiple of 4 and 100. If we express the second in the current way, we should check the divisibility for 4 and 100 (again) and then 400 to match the description, which is not the case here, even in the sample solution.
There was a problem hiding this comment.
@tqa236 I see what you mean - thanks for the suggestion. Could you open a new PR with that change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.