This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Lint maintainers #37
Merged
Lint maintainers #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nywilken
suggested changes
Jul 30, 2017
track/maintainer_config.go
Outdated
| "os" | ||
| ) | ||
|
|
||
| type MaintainerConfig struct { |
There was a problem hiding this comment.
Missing top level comment for exported types.
There was a problem hiding this comment.
Ah, I totally forgot to run the linter. My bad!
track/maintainer_config.go
Outdated
| AvatarURL string `json:"avatar_url"` | ||
| } | ||
|
|
||
| func NewMaintainerConfig(path string) (MaintainerConfig, error) { |
There was a problem hiding this comment.
Same linting issue as exported types; missing comment.
nywilken
reviewed
Jul 30, 2017
track/maintainer_config.go
Outdated
|
|
||
| func NewMaintainerConfig(path string) (MaintainerConfig, error) { | ||
| mc := MaintainerConfig{} | ||
| if _, err := os.Stat(path); os.IsNotExist(err) { |
nywilken
reviewed
Jul 30, 2017
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestBrokenMaintainerConfig(t *testing.T) { |
There was a problem hiding this comment.
I like this test pattern. Short, simple, and clearly showcases how linting for the maintainers file works.
|
I've added the linting. Merging this in. Thanks @nywilken |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a
maintainers.jsonfile, we're inevitably going to find that we delete fields without deleting the final comma. Or that someone adds the file to a track with a single maintainer, and makesmaintainersan object rather than an array.This includes the
maintainers.jsonin the linting process.