Skip to content
This repository has been archived by the owner on Mar 22, 2022. It is now read-only.

V3 Upgrades Part 1 #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

V3 Upgrades Part 1 #186

wants to merge 1 commit into from

Conversation

ekingery
Copy link
Contributor

Added validation and updated tests for new version and online_editor keys. See migrating-your-config-json-files.md for details.

@ekingery ekingery closed this Oct 22, 2020
@ekingery ekingery reopened this Oct 22, 2020
ErikSchierboom
ErikSchierboom approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! Does merging this automatically build a new release? If so, we should probably make this a draft PR to prevent it from being merged.

@ekingery
Copy link
Contributor Author

Does merging this automatically build a new release? If so, we should probably make this a draft PR to prevent it from being merged.

No, we have to manually build a new release for fetch_configlet to pick up a new version. So merging just "soft commits" us to implementing these changes in the next version.

Base automatically changed from master to main January 28, 2021 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekingery @ErikSchierboom