Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated concept docs and the docs #583

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Updated concept docs and the docs #583

merged 2 commits into from
Oct 31, 2022

Conversation

meatball133
Copy link
Member

@meatball133 meatball133 commented Oct 30, 2022 •
edited
Loading

Resolves #475

@meatball133 meatball133 changed the title resolves #475 Updated concept docs and the docs Oct 30, 2022
@meatball133
Copy link
Member Author

There is although a website which seems to be deprecated which we are still linking to: formatSpecifiers

@meatball133 meatball133 marked this pull request as draft October 31, 2022 12:17
ErikSchierboom
ErikSchierboom approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ErikSchierboom
Copy link
Member

Let me know when you're ready to have this merged

@meatball133
Copy link
Member Author

meatball133 commented Oct 31, 2022 •
edited
Loading

Out of the formatSpecifiers which seem bit outdated, I feel like the links are now up to date. I removed the link to swift education because it said the website was deprecated and replaced it with swift playground, I know it is a bit child themed but they have some nice tutorial on swift ui

@meatball133
Copy link
Member Author

meatball133 commented Oct 31, 2022 •
edited
Loading

Well since formatSpecifiers is used on multiple locations I feel like it is best to leave it be. The website is still there and working. I think I am ready to merge

@meatball133 meatball133 marked this pull request as ready for review October 31, 2022 13:36
@ErikSchierboom ErikSchierboom merged commit 95c8373 into exercism:main Oct 31, 2022
@ErikSchierboom
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check docs are up to date
2 participants
@meatball133 @ErikSchierboom