check-exercises: Move echo before test-exercise
#447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice that below `test-exercise` there is a check of `$?`. This means nothing should come after `text-exercise`. If we fail to do this, warnings will never cause the build to fail (as we would like them to), because the `$?` is examining the exit code of `echo`. We need to move the `echo` (progress dot) that we added in #446 a3a7b16
ijanos
approved these changes
Mar 5, 2018
coriolinus
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that below
test-exercisethere is a check of$?. This meansnothing should come after
text-exercise.If we fail to do this, warnings will never cause the build to fail (as
we would like them to), because the
$?is examining the exit code ofecho.We need to move the
echo(progress dot) that we added in#446
a3a7b16