Fixed inaccurate test/ignores. #362
Conversation
exercises/say/tests/say.rs
Outdated
| assert_eq!(say::encode(-1), String::from("won't compile")); | ||
| } | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
this is changing more lines than I expect it to change. A space got added before each line. That makes it hard to understand what changed, since now each line of this test is marked as a changed line. If this change (add space to each line) needs to be made for some reason, it would want to be a separate commit
exercises/say/tests/say.rs
Outdated
|
|
||
| #[test] | ||
| #[ignore] | ||
| #[should_panic] |
There was a problem hiding this comment.
I'm unsure should_panic makes sense, since who can say whether the test should panic if it doesn't even compile? I would not add such a line.
I kind of wish Rust would have a #[should_not_compile] or something, but that is something to bring up with the Rust project, I suppose
There was a problem hiding this comment.
I kind of wish Rust would have a
#[should_not_compile]
That is https://github.com/laumann/compiletest-rs apparently. a project for another day (and probably not something we can make students download)
exercises/say/tests/say.rs
Outdated
| @@ -15,8 +15,6 @@ fn test_zero() { | |||
| /* | |||
|
|
|||
| #[test] | |||
| #[ignore] | |||
There was a problem hiding this comment.
the #[ignore] should still be added, right? should not be removed
exercises/say/tests/say.rs
Outdated
| @@ -15,6 +15,7 @@ fn test_zero() { | |||
| /* | |||
|
|
|||
| #[test] | |||
| #[ignoe] | |||
|
Thanks! |
After creating a script to count tests/ignore amounts, this is a fix for the incorrect exercises.
#352