Protein translation (fix #267) #305
Conversation
* README didn't mention about compressed codons. So, test cases involing compressed codons have been removed or modified. * Example has been simplified because it no longer require codon 'decompression'.
* Added test cases for function `of_rna`, which translates a strand of RNA into a sequence of proteins per README. The test cases are copied from the test cases in [xpython](https://github.com/exercism/xpython/blob/master/exercises/protein-translation/protein_translation_test.py). * Added example for `of_rna`.
|
Nice, looks like it's more understandable as two commits. An interesting thing happened. The https://github.com/exercism/x-common/blob/master/exercises/protein-translation/description.md is talking about RNA (ACGU), but nucleotide-codons (https://github.com/exercism/x-common/blob/master/exercises/nucleotide-codons/description.md) used to talk about DNA (ACGT) before #258 blindly renamed nucleotide-codons to protein-translation. It would probably be for the best if all the T were changed to U, that's my fault. You can do it if you like otherwise I will have to soon. |
|
Ah. I see. I referenced wikipedia, and switched the DNA codons with RNA codons in a new commit. |
| } | ||
|
|
||
| #[test] | ||
| #[ignore] | ||
| fn test_arginine_name() { | ||
| let info = proteins::parse(make_pairs()); | ||
| assert_eq!(info.name_for("CGA"), Ok("arginine")); |
There was a problem hiding this comment.
removal intentional? I notice CGA is still an arginine in https://en.wikipedia.org/wiki/Genetic_code#RNA_codon_table
There was a problem hiding this comment.
My bad. That was a mistake. Let me add the missing ones.
There was a problem hiding this comment.
Very good, if nobody has anything else to say by the end of the weekend let's merge.
I would suggest to squash the last two commits together ("Replace DNA codons with RNA codons" + "Add some missing codons"). Feel free to do that, otherwise I will before merging.
Add some missing codons
go717franciswang
force-pushed
the
protein-translation
branch
from
3809b19 to
957079c
Compare
|
Done. The last 2 commits were squashed. |
|
All right. Thanks for the work! |
|
Awesome. Thanks! |
Split the earlier pull request into 2 commits -- remove tests for codon compression, and add tests for
of_rna. It resolves #267.