Add empty src/lib.rs files to all exercises #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertseng
approved these changes
Apr 3, 2017
There was a problem hiding this comment.
Thanks, great work.
I verified via for i in exercises/*/; do if [ ! -f $i/src/lib.rs ]; then echo "$i missing"; fi; done that all exercises now have stub files with this. Given that, and that there was general agreement in the referenced prior issues, it looks like this is good to merge immediately.
|
(I corrected a typo sill -> still, but of course that didn't stop us) |
petertseng
changed the title
petertseng
pushed a commit
that referenced
this pull request
Jul 23, 2017
This was referenced Jul 23, 2017
Merged
petertseng
added a commit
that referenced
this pull request
Jul 23, 2017
Now that we have an empty src/lib.rs for each exercise as of #270, we should ease the process of adding the file by no longer ignoring it.
petertseng
added a commit
that referenced
this pull request
Jul 23, 2017
As done in #270 Example of a failing build because of no src/lib.rs: https://travis-ci.org/exercism/rust/jobs/256643534
ErikSchierboom
pushed a commit
to ErikSchierboom/rust
that referenced
this pull request
Jan 26, 2021
* extract concepts from v2 exercise: macros Closes exercism/v3#245 * require mutability concept; remove extraneous note on Hashmap<K, V> * break out a more fine-grained list of concepts * Update languages/reference/exercise-concepts/macros.md Co-Authored-By: Eli Flanagan <[email protected]> Co-authored-by: Eli Flanagan <[email protected]>
ErikSchierboom
pushed a commit
to ErikSchierboom/rust
that referenced
this pull request
Jan 27, 2021
* extract concepts from v2 exercise: macros Closes exercism/v3#245 * require mutability concept; remove extraneous note on Hashmap<K, V> * break out a more fine-grained list of concepts * Update languages/reference/exercise-concepts/macros.md Co-Authored-By: Eli Flanagan <[email protected]> Co-authored-by: Eli Flanagan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #117, #200, and #269.
Since the jury is sill out on whether/how to provide stub functions, I opted to simply add empty files in this commit. This makes for a smoother user experience, as students will no longer have to invoke
mkdir src; touch src/lib.rsfor every exercise.