Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hello-world GETTING_STARTED.md to match simplified exercise #266

Merged

Conversation

jgallagher
Copy link

Closes #265.

Copy link
Contributor

@IanWhitney IanWhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Let's get this merged now.

For anyone looking for future directions, maybe it will be useful to relate what happens in hello-world with the rest of the track. "In future exercises, you will follow a similar process, ..." etc. Would have to think about whether that is best placed in this file or some file in the next exercise.

@petertseng petertseng merged commit 61be027 into exercism:master Mar 10, 2017
@jgallagher jgallagher deleted the update-hello-world-getting-started branch March 10, 2017 15:54
@jgallagher
Copy link
Author

One thing I noticed looking at the next several exercises is that most of them don't include a src/lib.rs at all, but a few have one with all the necessary public functions defined (with unimplemented!() bodies). The latter seems a lot smoother to pick up and would reduce the need for extra process instructions compared to the former.

@petertseng
Copy link
Member

What I see from #117 and #200 is definite agreement there should be a src/lib.rs. There wasn't agreement on whether it should be empty or contain the function signatures.

I think we can get wider agreement on signatures for the initial exercises, to help people start. On later exercises, even if we can't agree, an empty src/lib.rs would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants