implement zipper #783
Merged
implement zipper #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
force-pushed
the
implement-zipper
branch
from
e89ed84 to
deb6fea
Compare
ilya-khadykin
suggested changes
Oct 21, 2017
exercises/zipper/zipper.py
Outdated
| self.parent = None if parent is None else dict(parent) | ||
|
|
||
| def value(self): | ||
| return self.root['value'] |
There was a problem hiding this comment.
Should pass here I guess
exercises/zipper/zipper_test.py
Outdated
|
|
||
| from zipper import Zipper | ||
|
|
||
|
|
There was a problem hiding this comment.
Could you please also leave a comment stating what version of canonical-data.json the tests were adopted as discussed in #784 if aplicable?
The format is:
# Tests adapted from `problem-specifications//canonical-data.json` @ v1.0.0
exercises/zipper/zipper.py
Outdated
| return Zipper(tree) | ||
|
|
||
| def __init__(self, root, parent=None): | ||
| self.root = dict(root) |
|
@m-a-ge Requested changes made. |
|
Thanks, @cmccandless 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #736
TODO:
config.jsonzipper.py)zipper_test.pyexample.py)