Add parameters to exercise placeholder #693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allergies - alphametics - anagram - atbase-cipher - beer-song - binary - binary-search - bob - book-store
|
Hi, @AllanNozomu. I'm glad to see your PR. Please note, as I mentioned in #631 (comment), I've intentionally created a separate issue for each exercise for the following reasons:
It was tempting to solve all the issues in one PR, but it's hard to review it. I hope you'll understand the decision. |
|
Sorry, about that, I will close this PR |
|
@AllanNozomu no worries and thanks for your understanding 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issues (539 - 547)
I think the bracket-push don't need a parameter, since the name string is good for this case.
I renamed the parameter to the names used in example.py