sublist: add parameters to exercise placeholder #692
Conversation
exercises/sublist/sublist.py
Outdated
| @@ -1,2 +1,2 @@ | |||
| def check_lists(): | |||
| def check_lists(firstList, secondList): | |||
There was a problem hiding this comment.
Python favors snake_case over CamelCase.
A good Python style guide from Google - https://google.github.io/styleguide/pyguide.html?showone=Naming#Naming
Could you please change it?
There was a problem hiding this comment.
Sorry for this, I just started to using Python and I've never seen this guide before. So i just have to change firstList to first_list and secondList to second_list. Thanks for the guide.
There was a problem hiding this comment.
@cruxiu you're welcome
|
The Travis CI build hasn't yet completed his execution, so i need to close this PR, then open it again for trigger a new build? |
|
@cruxiu there is no need, it takes some time. Congrats on your first contribution to the repo It's a best practice to squash your commits https://github.com/exercism/docs/blob/master/contributing/git-basics.md#squashing. It isn't a big deal since I can do it myself, but it would be awesome to just click on 'Merge pull request' button 😃 Please also note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge. |
Added the
firstListandsecondListparameters to the abbreviate method to ensure clarity to future users. This change was discussed in issue #509.Fixes #643