Difference of Squares - Added Parameters to placeholders #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-khadykin
suggested changes
Oct 4, 2017
| pass | ||
|
|
||
|
|
||
| def difference(): | ||
| def difference(square_of_sum, sum_of_squares): |
There was a problem hiding this comment.
difference takes only one parameter according to https://github.com/exercism/python/blob/master/exercises/difference-of-squares/difference_of_squares_test.py
| @@ -1,10 +1,10 @@ | |||
| def square_of_sum(): | |||
| def square_of_sum(square_of_sum): | |||
There was a problem hiding this comment.
This conflicts with the exercise itself, it requires only number
Updated the function `difference` by deleting a conflicting parameter.
|
@m-a-ge are these the changes you wanted? |
|
@Sukhj1nder No, not really. |
Made the Parameter in the `difference` function less confusing.
|
@m-a-ge hopefully this is better |
This was referenced Oct 7, 2017
|
@Sukhj1nder Are you still working on this? |
|
Sorry guys, I have gotten busier with some of my other projects. Hopefully it gets finished but, I hope to see you guys in the future when I've finished my projects so I can contribute further into this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Parameters to the Difference of Squares file in the functions
square_of_sum,sum_of_squaresanddifference.This resolves the issue #585.
TODO: Difference of Squares - Ticked on #509
Resolves #555