Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello_word added parameter to exercise placeholder #584

Merged
merged 2 commits into from
Oct 5, 2017
Merged

hello_word added parameter to exercise placeholder #584

merged 2 commits into from
Oct 5, 2017

Conversation

Sukhj1nder
Copy link
Contributor

@Sukhj1nder Sukhj1nder commented Oct 3, 2017

Added Parameters to the Hello World file in the functions hello.

This resolves the issue #584.
TODO: Hello World - Ticked on #509

Fixes #563

@@ -1,2 +1,2 @@
def hello():
def hello(input):
Copy link
Contributor

@ilya-khadykin ilya-khadykin Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by https://github.com/exercism/python/blob/master/exercises/hello-world/hello_world_test.py hello-world doesn't expect any parameters.
And input option is too general; name is much better

I suggest add a default parameter def hello(name='') to not confuse users

Updated the Parameter name in the `hello_world` function.

Hope this is better.
@Sukhj1nder
Copy link
Contributor Author

@m-a-ge hope this is better 👍

@ilya-khadykin ilya-khadykin merged commit 575df84 into exercism:master Oct 5, 2017
@ilya-khadykin
Copy link
Contributor

Thanks, @Sukhj1nder

It's a best practice to squash your commits https://github.com/exercism/docs/blob/master/contributing/git-basics.md#squashing. It isn't a big deal since I can do it myself, but it would be awesome to just click on 'Merge pull request' button 😃

Please note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
It makes our work much easier. I hope this hint will help you to make your future PRs a bit better

Guide on how to write good commit messages - https://chris.beams.io/posts/git-commit/#seven-rules

@Sukhj1nder Sukhj1nder deleted the patch-1 branch October 5, 2017 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hello-world: add parameters to exercise placeholder
2 participants